-
Notifications
You must be signed in to change notification settings - Fork 13.4k
SYCL SET operator optimized for F32 tensors #16350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYCL SET operator optimized for F32 tensors #16350
Conversation
Hi @ggerganov, just following up kindly on this PR. |
Hi @NeoZhangJianyu, I noticed you’ve reviewed SYCL-related PRs before. |
Hi @CISC and @NeoZhangJianyu, All tests directly related to my changes have passed successfully. Everything in the SYCL SET operator implementation is correct, properly formatted, and verified locally. Thanks a lot for your time and support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good work!
Thank you!
@GittyBurstein When they are passed, I will merge the PR. Thank you! |
SYCL F32 SET Operator Implementation
This PR implements the
SET
operator forF32
in SYCL. This is the first implementation ofSET
in SYCL.All tests for F32 passed successfully, ensuring correctness. The implementation preserves the existing library structure and follows GGML conventions.
Performance Improvements
Changed Files
ggml/src/ggml-sycl/ggml-sycl.cpp
ggml/src/ggml-sycl/set.cpp
ggml/src/ggml-sycl/set.hpp
Technical Details
parallel_for
to perform element-wiseSET
operations.set_f32
converts a linear index to multi-dimensional indices for accurate copying.Example